fix(TaskProcessingApiController): use StreamResponse to return file content #53277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-nc
requested review from
ArtificialOwl,
come-nc and
yemkareems
and removed request for
a team
kyteinsky
reviewed
Jun 3, 2025
julien-nc
reviewed
Jun 3, 2025
…sk file content Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
oleksandr-nc
force-pushed
the
fix/noid/task-processing-file-content-stream
branch
from
cac8136 to
90e8fa2
Compare
julien-nc
approved these changes
Jun 3, 2025
|
/backport to stable31 |
Merged
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We encountered a situation when the file size for task processing exceeds 512 megabytes (default memory limit for PHP) - and ExApp (stt_whisper2) cannot receive the file for transcription to process it.
Using
StreamResponseinstead ofDataDownloadResponseshould not break API compatibility, and should reduce not only resource consumption in the case of AI tasks, but also allow our AI applications to accept files of unlimited size for processing.Checklist