Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions webpack.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@ const config = {
codecovWebpackPlugin({
enableBundleAnalysis: !isDev && !isTesting,
bundleName: 'nextcloud',
telemetry: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative:

Suggested change
telemetry: false,
telemetry: !!process.env.CI,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have a strong opinion on this. Are you aware that telemetry data is unrelated to bundle analytics and is solely about collecting data? Or do you see anything in Requests 1 and 2 that looks related to the bundle analytics?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey again from Codecov! You're correct that telemetry is just for our internal usage metrics/error reporting/etc. It won't affect the functionality to disable telemetry. Let me know if you folks have any further questions about anything 🙂

}),
],
externals: {
Expand Down
Loading