Skip to content

fix(files): auto reload sidebar tags on update #53140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

skjnldsv
Copy link
Member

Ideally, the Sidebar would already handle a Node object. Avoiding us the pain of fetching the node again.
But until then, we'll do a full refresh. It should be alright for now :)

Peek.27-05-2025.15-07.mp4

@skjnldsv skjnldsv added this to the Nextcloud 32 milestone May 27, 2025
@skjnldsv skjnldsv self-assigned this May 27, 2025
@skjnldsv skjnldsv requested a review from a team as a code owner May 27, 2025 13:08
@skjnldsv skjnldsv requested review from susnux, artonge and szaimen and removed request for a team May 27, 2025 13:08
@skjnldsv skjnldsv added the bug label May 27, 2025
@skjnldsv skjnldsv added 3. to review Waiting for reviews feature: files feature: tags feature: file sidebar Related to the file sidebar component labels May 27, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 📁 Files team May 27, 2025
@skjnldsv
Copy link
Member Author

/backport to stable31

@skjnldsv
Copy link
Member Author

/backport to stable30

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@susnux susnux force-pushed the fix/auto-reload-tags branch from 4c9140b to ad16a97 Compare May 27, 2025 15:23
@susnux
Copy link
Contributor

susnux commented May 27, 2025

/compile

@susnux susnux enabled auto-merge May 27, 2025 15:24
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command requested a review from a team as a code owner May 27, 2025 15:28
@susnux
Copy link
Contributor

susnux commented May 27, 2025

@skjnldsv cypress related:

Systemtags: Files integration
✓ See first assigned tag in the file list (7413ms)
(Attempt 1 of 3) See two assigned tags are also shown in the file list
(Attempt 2 of 3) See two assigned tags are also shown in the file list
1) See two assigned tags are also shown in the file list
(Attempt 1 of 3) See three assigned tags result in overflow entry
(Attempt 2 of 3) See three assigned tags result in overflow entry
2) See three assigned tags result in overflow entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗️ In progress
Development

Successfully merging this pull request may close these issues.

5 participants