Drop unused jquery multiselect widget #53113
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elchukc
requested review from
nfebe,
skjnldsv,
szaimen and
leftybournes
and removed request for
a team
Signed-off-by: Clare Elchuk <clareelchuk@gmail.com>
Signed-off-by: Clare Elchuk <clareelchuk@gmail.com>
elchukc
force-pushed
the
drop_jqery_multiselect_widget
branch
from
6184d57 to
403462e
Compare
szaimen
added
enhancement
3. to review
elchukc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes 4 out of 5 uses of jquery-ui highlighted in #12980. The last one was a tooltip that was deleted in PR#37244.
I did my best to remove all jquery-ui uses in
user_ldap/but jquery is unfamiliar to me and it's hard to tell if I'm missing anything.After a bunch of digging around in the documentation, I still cannot get any of the automated tests or php linting to work, although did run
npm run lint:fixTODO
Checklist