feat(dav): add custom classification levels for events in public calendars #53073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndars The CLASS:PRIVATE and CLASS:CONFIDENTIAL apply to events shared as well as published ones. This adds two new custom CLASS values: X-NEXTCLOUD-CLASS-PUBLISHED-PRIVATE and X-NEXTCLOUD-CLASS-PUBLISHED-CONFIDENTIAL, which work the same as the standard values, but only when they are published into a public calendar. Therefore, you can set an event to be public (fully visible) for people who you shared internally the event's calendar, but private when the calendar is published. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
added
3. to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
CLASS:PRIVATEandCLASS:CONFIDENTIALapply to events shared (with other people or groups, internally) as well as published ones (which are public for everyone with the link). This can be troublesome, as some events shouldn't be publicly visible in the published calendar, either not at all or just handled as confidential (only timeranges shown)¹.This adds two new custom
CLASSvalues:X-NEXTCLOUD-CLASS-PUBLISHED-PRIVATEandX-NEXTCLOUD-CLASS-PUBLISHED-CONFIDENTIAL, which work the same as the standard values, but only when they are published into a public calendar.Therefore, you can set an event to be public (fully visible) for people who you shared internally the event's calendar, but private when the calendar is published.
This is the part on the server, part in the calendar front-end and libraries is yet to be written and designed.
¹ I also plan to work on a "confidential calendar publish mode", where only timeranges of events are shown.
Checklist