Skip to content

Conversation

@georgehrke
Copy link
Member

backport of #5298
fixes #4885

@georgehrke georgehrke added the 3. to review Waiting for reviews label Jun 8, 2017
@georgehrke georgehrke added this to the Nextcloud 12.0.1 milestone Jun 8, 2017
@georgehrke georgehrke requested a review from rullzer June 8, 2017 07:12
@mention-bot
Copy link

@georgehrke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @tcitworld and @schiessle to be potential reviewers.

@georgehrke georgehrke changed the title urldecode group principals in Cal- and CardDAV backend [stable12] urldecode group principals in Cal- and CardDAV backend Jun 8, 2017
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the bugfix-stable12/4885/calendar_shares_url_special_char_issue branch from 0679f60 to dba4935 Compare June 12, 2017 19:02
@codecov
Copy link

codecov bot commented Jun 12, 2017

Codecov Report

Merging #5299 into stable12 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable12    #5299      +/-   ##
==============================================
+ Coverage       54.18%   54.18%   +<.01%     
  Complexity      22296    22296              
==============================================
  Files            1380     1380              
  Lines           85347    85351       +4     
  Branches         1322     1322              
==============================================
+ Hits            46244    46247       +3     
- Misses          39103    39104       +1
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/CalDAV/CalDavBackend.php 86.03% <100%> (+0.02%) 218 <0> (ø) ⬇️
apps/dav/lib/CardDAV/CardDavBackend.php 85.74% <100%> (+0.06%) 88 <0> (ø) ⬇️
apps/comments/lib/EventHandler.php 79.16% <0%> (-8.34%) 7% <0%> (ø)
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants