Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/files_sharing/src/views/SharingDetailsTab.vue
Original file line number Diff line number Diff line change
Expand Up @@ -905,8 +905,9 @@ export default {
this.advancedSectionAccordionExpanded = true
}

if (this.share.note) {
if (this.isValidShareAttribute(this.share.note)) {
this.writeNoteToRecipientIsChecked = true
this.advancedSectionAccordionExpanded = true
}

},
Expand Down
3 changes: 1 addition & 2 deletions cypress/e2e/files_sharing/note-to-recipient.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ describe('files_sharing: Note to recipient', { testIsolation: true }, () => {
cy.get('[data-cy-sidebar]').within(() => {
// Open the share
cy.get('[data-cy-files-sharing-share-actions]').first().click({ force: true })
// Open the custom settings
cy.get('[data-cy-files-sharing-share-permissions-bundle="custom"]').click()

cy.findByRole('checkbox', { name: /note to recipient/i })
.and('be.checked')
Expand All @@ -90,4 +88,5 @@ describe('files_sharing: Note to recipient', { testIsolation: true }, () => {
.and('have.value', 'Hello, this is the note.')
})
})

})
2 changes: 0 additions & 2 deletions dist/3421-3421.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/3421-3421.js.map

This file was deleted.

1 change: 0 additions & 1 deletion dist/3421-3421.js.map.license

This file was deleted.

2 changes: 2 additions & 0 deletions dist/923-923.js

Large diffs are not rendered by default.

File renamed without changes.
1 change: 1 addition & 0 deletions dist/923-923.js.map

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions dist/923-923.js.map.license
4 changes: 2 additions & 2 deletions dist/files_sharing-files_sharing_tab.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files_sharing-files_sharing_tab.js.map

Large diffs are not rendered by default.

Loading