Skip to content

fix(accounts): enhance UX for groups assignment #52776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 2, 2025
Merged

fix(accounts): enhance UX for groups assignment #52776

merged 4 commits into from
Jun 2, 2025

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented May 12, 2025 •
edited by susnux
Loading

Summary

  • For instance admins, information is already available from pinia store. We just reuse it for NcSelectOptions and populate the store from group search requests (like we would do with scrolling navigation)
  • For subadmins, only available groups can be managed/changed. But they've been missing from navigation, so re-added there
Role Before After
Admin (select) 2025-05-17_11h07_11 2025-05-17_11h09_05
Subadmin (nav) 2025-05-17_11h07_45 2025-05-17_11h08_22
Subadmin (select) 2025-05-17_11h07_36 2025-05-17_11h08_39

TODO

  • ...

Checklist

@Antreesy Antreesy added this to the Nextcloud 32 milestone May 12, 2025
@Antreesy Antreesy self-assigned this May 12, 2025
@Antreesy
Copy link
Contributor Author

/compile

@Antreesy Antreesy added 3. to review Waiting for reviews feature: users and groups and removed 2. developing Work in progress labels May 17, 2025
@Antreesy Antreesy marked this pull request as ready for review May 17, 2025 09:21
@Antreesy Antreesy requested review from a team as code owners May 17, 2025 09:21
@Antreesy Antreesy requested review from artonge, sorbaugh and susnux and removed request for a team May 17, 2025 09:21
@susnux
Copy link
Contributor

susnux commented May 17, 2025

/backport to stable31

@susnux
Copy link
Contributor

susnux commented May 17, 2025

/backport to stable30

@Antreesy Antreesy requested review from ShGKme and skjnldsv May 19, 2025 07:45
@cdammanintopix cdammanintopix mentioned this pull request May 28, 2025
Closed
8 tasks
Antreesy added 3 commits June 2, 2025 08:53
@Antreesy
fix(NewUserDialog): retrieve available groups from the store
b43bcae 
- fix 'this.isAdmin' to be 'this.settings.isAdmin'
- compute 'availableGroups' instead of setting it once mounted
- populate store and 'availableGroups' from search requests

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(UserRow): retrieve available groups from the store
875b8cf 
- rename 'available*Groups' to 'selected*Groups'
- populate store and 'availableGroups' from search requests

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(AppNavigationGroupList): restore navigation panel and search/filt…
b52aae0 
…er functionality for sub-admin groups

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/52590/available-account-groups branch from 3624db9 to b52aae0 Compare June 2, 2025 07:01
@Antreesy
Copy link
Contributor Author

Antreesy commented Jun 2, 2025

/compile

@nextcloud-command
chore(assets): Recompile assets
97c7d93 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Antreesy Antreesy merged commit cc3fdf8 into master Jun 2, 2025
124 checks passed
@Antreesy Antreesy deleted the fix/52590/available-account-groups branch June 2, 2025 07:19
This was referenced Jun 2, 2025
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux susnux approved these changes

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels

3. to review Waiting for reviews enhancement feature: users and groups

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[Bug]: Unclear UX when editing account groups [Bug]: For subadmins, the accounts page does not list the groups.

6 participants

@Antreesy @susnux @AndyScherzinger @skjnldsv @nextcloud-command