Skip to content

fix(updatenotification): respect updatechecker config #52771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

fix(updatenotification): respect updatechecker config #52771

merged 1 commit into from
May 12, 2025

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented May 12, 2025 •
edited by kesselb
Loading

Close #52125

Summary

If disabled:

  • Hide admin settings
  • Do not create Nextcloud server update notifications

Checklist

@susnux susnux added this to the Nextcloud 32 milestone May 12, 2025
@susnux susnux requested a review from a team as a code owner May 12, 2025 13:17
@susnux susnux added bug 3. to review Waiting for reviews labels May 12, 2025
@susnux susnux requested review from ArtificialOwl, icewind1991 and sorbaugh and removed request for a team May 12, 2025 13:17
@susnux susnux self-assigned this May 12, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 📁 Files team May 12, 2025
@susnux susnux requested a review from szaimen May 12, 2025 13:17
@szaimen
Copy link
Contributor

szaimen commented May 12, 2025

/backport to stable31

szaimen
szaimen approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the hiding of the admin UI and seems to work. Thanks! :)

But tests are failing...

@szaimen szaimen mentioned this pull request May 12, 2025
Closed
@susnux susnux force-pushed the fix/update-notification-respect-config branch from dc8870c to 7af92c9 Compare May 12, 2025 15:47
@susnux
fix(updatenotification): respect updatechecker config
957efe0 
If disabled:
- Hide admin settings
- Do not create Nextcloud server update notifications

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/update-notification-respect-config branch from 7af92c9 to 957efe0 Compare May 12, 2025 16:06
@susnux susnux merged commit d0e9e2c into master May 12, 2025
218 of 233 checks passed
@susnux susnux deleted the fix/update-notification-respect-config branch May 12, 2025 21:30
@backportbot backportbot bot mentioned this pull request May 12, 2025
Merged
@susnux susnux moved this from 🏗️ In progress to ☑️ Done in 📁 Files team May 13, 2025
This was referenced Jun 12, 2025
Closed
Open
@kesselb kesselb mentioned this pull request Jun 27, 2025
Closed
8 tasks
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtificialOwl ArtificialOwl ArtificialOwl approved these changes

@icewind1991 icewind1991 icewind1991 approved these changes

@szaimen szaimen szaimen approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@susnux susnux

Labels

3. to review Waiting for reviews bug feature: install and update

Projects

📁 Files team
Status: ☑️ Done

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[Bug]: setting 'updatechecker' => false does not disable update notifications

7 participants

@susnux @szaimen @ArtificialOwl @icewind1991 @joshtrichards @skjnldsv