fix(apps): Sort names separately from active/update state #52583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kent Delante <kent.delante@proton.me>
leftybournes
requested review from
sorbaugh,
susnux and
szaimen
and removed request for
a team
susnux
approved these changes
May 2, 2025
artonge
approved these changes
May 5, 2025
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes apps names starting with numbers getting sorted incorrectly because of prepending active and update state as numbers to the name (i.e. 013D Model Viewer for an app called 3D Model Viewer). Apps with names starting with numbers get pushed to the bottom of the list because of the larger value compared to apps without numbers in names (i.e. 013D Model Viewer vs 01Files).
Checklist