fix(files_sharing): Prevent create/delete permissions on file shares #52526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
requested review from
AndyScherzinger,
artonge,
skjnldsv,
sorbaugh and
susnux
yemkareems
approved these changes
Apr 29, 2025
susnux
approved these changes
Apr 29, 2025
nfebe
force-pushed
the
fix/no-issue/prevent-create-delete-perms-on-file-shares
branch
from
dd40338 to
a124da4
Compare
|
/compile |
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
|
/compile |
File shares can't support create or delete permissions. This change ensures those permissions are stripped or ignored when the shared item is not a folder. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/no-issue/prevent-create-delete-perms-on-file-shares
branch
from
a124da4 to
99ae04d
Compare
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nfebe
deleted the
fix/no-issue/prevent-create-delete-perms-on-file-shares
branch
This was referenced Apr 29, 2025
|
Thanks a lot for the swift fix 🙏 |
18 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File shares can't support create or delete permissions. This change ensures those permissions are stripped or ignored when the shared item is not a folder.