Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Apr 23, 2025

Summary

The P formatter is 64bit only - we need to manually pack the 64bit.

Checklist

The `P` formatter is 64bit only - we need to manually pack the 64bit.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux requested a review from a team as a code owner April 23, 2025 21:32
@susnux susnux requested review from Altahrim, come-nc and provokateurin and removed request for a team April 23, 2025 21:32
@susnux susnux added bug 3. to review Waiting for reviews regression feature: 32bits Bug specific to 32bits architectures labels Apr 23, 2025
@susnux susnux added this to the Nextcloud 32 milestone Apr 23, 2025
@come-nc come-nc merged commit 7a50f61 into master Apr 24, 2025
212 of 218 checks passed
@come-nc come-nc deleted the fix/32bit-support branch April 24, 2025 07:53
@come-nc
Copy link
Contributor

come-nc commented Apr 24, 2025

@come-nc
Copy link
Contributor

come-nc commented Apr 24, 2025

@susnux CI failed:

There were 2 failures:

1) Test\Security\Normalizer\IpAddressTest::testGetSubnet with data set #5 ('2001:0db8:0000:0000:0000:8a2e...0:7334', '2001:db8::/56')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'2001:db8::/56'
+'2001::/56'

/__w/server/server/tests/lib/Security/Normalizer/IpAddressTest.php:64

2) Test\Security\Normalizer\IpAddressTest::testGetSubnet with data set #6 ('2001:db8:3333:4444:5555:6666:7777:8888', '2001:db8:3333:4400::/56')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'2001:db8:3333:4400::/56'
+'2001:0:3333:4400::/56'

/__w/server/server/tests/lib/Security/Normalizer/IpAddressTest.php:64

susnux added a commit that referenced this pull request Apr 24, 2025
* Typo from #52392

`0xFFFF` is only 2 bytes, but we need either `0xFFFFFFFF` or maybe a bit
easier to read `PHP_INT_MAX`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux added a commit that referenced this pull request Apr 28, 2025
* Typo from #52392

`0xFFFF` is only 2 bytes, but we need either `0xFFFFFFFF` or maybe a bit
easier to read `PHP_INT_MAX`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
backportbot bot pushed a commit that referenced this pull request Apr 28, 2025
* Typo from #52392

`0xFFFF` is only 2 bytes, but we need either `0xFFFFFFFF` or maybe a bit
easier to read `PHP_INT_MAX`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
backportbot bot pushed a commit that referenced this pull request Apr 28, 2025
* Typo from #52392

`0xFFFF` is only 2 bytes, but we need either `0xFFFFFFFF` or maybe a bit
easier to read `PHP_INT_MAX`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
SebastianKrupinski pushed a commit that referenced this pull request May 8, 2025
* Typo from #52392

`0xFFFF` is only 2 bytes, but we need either `0xFFFFFFFF` or maybe a bit
easier to read `PHP_INT_MAX`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
AIlkiv pushed a commit to AIlkiv/server that referenced this pull request Jul 10, 2025
* Typo from nextcloud#52392

`0xFFFF` is only 2 bytes, but we need either `0xFFFFFFFF` or maybe a bit
easier to read `PHP_INT_MAX`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug feature: 32bits Bug specific to 32bits architectures regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants