fix(LDAP): inlcude ldapExpertUsernameAttr in general attribute list #52257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes corner cases in which an LDAP record might be loaded and used, where the user is still not mapped - and then this information is missing though expected. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
a team,
ArtificialOwl,
come-nc,
nickvergessen and
provokateurin
and removed request for
a team
|
/backport to stable31 |
provokateurin
approved these changes
Apr 17, 2025
come-nc
approved these changes
Apr 22, 2025
|
From what I remember of the analysis this does not fix all code paths, but should help with most. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes corner cases in which an LDAP record might be loaded and used, where the user is still not mapped - and then this information is missing though expected.
This was never an issue, until preferences started to throw
InvalidArgumentExceptioninUserConfig::assertParamsalthough it's not documented.