fix(S3): Use original folder size during copy

[artonge]

This prevents having copied folders with a wrongly set size of 0KB.

• Fix [Bug]: Object storage (S3) folder on duplication has 0 KB folder size #51916

Not sure about the handleCopiesAsOwned part, but I kept it from copyFile to preserve the same behaviour. It was introduced in #41565. Maybe @susnux you can judge whether it makes sense or not. Validated.

[artonge]

/backport to stable31

[artonge]

/backport to stable30

[artonge]

/backport to stable29

[icewind1991]

The least-invasive change would probably be to pass the needed metadata to mkdir

Alternatively you can first do the recursive cache copy, and then do the object copy recursively without changing the cache. (care has to be taken than to not have the db and object store desync if the object copy fails then)

[DaphneMuller]

@artonge anything that we should be doing here to follow up on it?

[artonge]

@artonge anything that we should be doing here to follow up on it?

No, just prioritizing :)

[codecov]

❌ Unsupported file format

Upload processing failed due to unsupported file format. Please review the parser error message:

Error deserializing json

Caused by:
    expected value at line 1 column 1

For more help, visit our troubleshooting guide.

[artonge]

The least-invasive change would probably be to pass the needed metadata to mkdir

Alternatively you can first do the recursive cache copy, and then do the object copy recursively without changing the cache. (care has to be taken than to not have the db and object store desync if the object copy fails then)

@icewind1991 I ended up keeping the mkdir as is, and updating its size right after.

[DaphneMuller]

@artonge @icewind1991 any chance this can be merged soon?

[icewind1991]

@icewind1991 I ended up keeping the mkdir as is, and updating its size right after.

Pushed a change to do the size in the mkdir, there is no need to do 3 queries to the filecache when 1 can suffice.

Also pushed a test to ensure this doesn't regress.