Skip to content

chore(i18n): Use "name" instead of "nickname" #52094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025
Merged

chore(i18n): Use "name" instead of "nickname" #52094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b27d760
chore(i18n): Use "name" instead of "nickname"
rakekniven Apr 10, 2025
a68e035
chore(assets): Recompile assets
nextcloud-command Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/files_sharing/src/views/PublicAuthPrompt.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
<NcTextField ref="input"
class="public-auth-prompt__input"
data-cy-public-auth-prompt-dialog-name
:label="t('files_sharing', 'Nickname')"
:placeholder="t('files_sharing', 'Enter your nickname')"
:label="t('files_sharing', 'Name')"
:placeholder="t('files_sharing', 'Enter your name')"
minlength="2"
name="name"
required
Expand Down
4 changes: 2 additions & 2 deletions cypress/e2e/files_sharing/file-request.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ const enterGuestName = (name: string) => {
cy.findByRole('dialog', { name: /Upload files to/ })
.should('be.visible')
.within(() => {
cy.findByRole('textbox', { name: 'Nickname' })
cy.findByRole('textbox', { name: 'Name' })
.should('be.visible')

cy.findByRole('textbox', { name: 'Nickname' })
cy.findByRole('textbox', { name: 'Name' })
.type(`{selectall}${name}`)

cy.findByRole('button', { name: 'Submit name' })
Expand Down
2 changes: 2 additions & 0 deletions dist/6872-6872.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 dist/8749-8749.js.license → dist/6872-6872.js.license
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions dist/6872-6872.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions dist/6872-6872.js.map.license
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
6872-6872.js.license
2 changes: 0 additions & 2 deletions dist/8749-8749.js
View file
Open in desktop

This file was deleted.

Loading
Loading