fix(files_sharing): fix share creation error handling #52075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
icewind1991,
nfebe,
susnux,
szaimen and
yemkareems
and removed request for
a team
skjnldsv
force-pushed
the
fix/sharing-error-catch
branch
2 times, most recently
from
94a3378 to
367ef8d
Compare
|
/backport 70218dc to stable31 |
|
/backport 70218dc to stable30 |
|
/backport 70218dc to stable29 |
skjnldsv
force-pushed
the
fix/sharing-error-catch
branch
from
367ef8d to
2c2239c
Compare
nfebe
approved these changes
Apr 9, 2025
|
/compile rebase |
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/sharing-error-catch
branch
from
2c2239c to
309d568
Compare
skjnldsv
added
4. to release
This was referenced Apr 9, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When creating a share which triggers an error, I noticed some issues:
Error creating the share: Failed to create share, which is really not acceptableHow to test:
Folder1from user1 to user2Folder2Folder2to user3Expectations
Error stating:
Error creating the share: You cannot share a folder that contains other sharesReality
Error stating
Error creating the share: Failed to create share(And the logs states a weirdly phrased error which is also renamed in that PR:
Path contains files shared with you)