Skip to content

fix(files_reminders): add missing import #51944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2025
Merged

fix(files_reminders): add missing import #51944

merged 3 commits into from
Apr 7, 2025

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Apr 4, 2025 •
edited
Loading

Summary

  1. Add missing import of setup check in application class
  2. Add missing l10n constructor parameter.
  3. Lint the app using psalm so this does not happen again.

Checklist

@susnux susnux requested a review from a team as a code owner April 4, 2025 14:31
@susnux susnux requested review from ArtificialOwl, artonge, nfebe and yemkareems and removed request for a team April 4, 2025 14:31
@susnux susnux added bug 3. to review Waiting for reviews regression labels Apr 4, 2025
@susnux susnux added this to the Nextcloud 31.0.3 milestone Apr 4, 2025
@susnux susnux requested a review from ChristophWurst April 4, 2025 14:34
@susnux
Copy link
Contributor Author

susnux commented Apr 4, 2025

/backport to stable31

@susnux
Copy link
Contributor Author

susnux commented Apr 4, 2025

/backport to stable30

@susnux
Copy link
Contributor Author

susnux commented Apr 4, 2025

/backport to stable29

@susnux susnux mentioned this pull request Apr 4, 2025
Merged
kesselb
kesselb previously requested changes Apr 7, 2025
View reviewed changes
come-nc
come-nc reviewed Apr 7, 2025
View reviewed changes
apps/files_reminders/lib/SetupChecks/NeedNotificationsApp.php Outdated
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

namespace OCA\DAV\SetupChecks;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed that’s worrying. We have no check for namespace<>path consistency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can psalm do this?

susnux added 3 commits April 7, 2025 10:56
@susnux
fix(files_reminders): add missing import
a682049 
- Resolves #51943

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(files_reminders): add l10n to constructor of setup check
d79070c 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: lint files_reminders using psalm
c0212af 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/missing-import branch from 8f3abc4 to c0212af Compare April 7, 2025 08:56
@susnux susnux requested review from come-nc and kesselb April 7, 2025 08:56
@kesselb kesselb merged commit 07278d2 into master Apr 7, 2025
195 of 198 checks passed
@kesselb kesselb deleted the fix/missing-import branch April 7, 2025 09:38
This was referenced Apr 7, 2025
Merged
Merged
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@yemkareems yemkareems yemkareems approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@kesselb kesselb Awaiting requested review from kesselb

@come-nc come-nc Awaiting requested review from come-nc

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug regression

Projects

None yet

Milestone

Nextcloud 31.0.3

Development

Successfully merging this pull request may close these issues.

[Bug]: Could not resolve OCA\FilesReminders\AppInfo\NeedNotificationsApp

7 participants

@susnux @kesselb @artonge @skjnldsv @yemkareems @come-nc