fix(session): Only mark sessions of permanent tokens as app passwords #51905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
Altahrim,
come-nc and
nfebe
and removed request for
a team
|
/backport! to stable31 |
|
/backport! to stable30 |
|
/backport! to stable29 |
This was referenced Apr 3, 2025
AndyScherzinger
approved these changes
Apr 3, 2025
susnux
approved these changes
Apr 3, 2025
st3iny
approved these changes
Apr 3, 2025
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 💌 📅 👥 Groupware team
This was referenced Apr 9, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a logic error of #24552. As noticed in nextcloud/globalsiteselector#51 (comment) the check should be on the token type, not the remember property.
How to test
master: app_password key is saved to the session
here: app_password key does not exist in session
TODO
Checklist