Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 25, 2025

Otherwise contacts without an email address would still show up when sharing or adding them to a circle, which is not possible as there is no destination to share to

@juliusknorr juliusknorr requested a review from a team as a code owner March 25, 2025 22:23
@juliusknorr juliusknorr requested review from Altahrim, artonge, blizzz, nfebe, provokateurin and yemkareems and removed request for a team March 25, 2025 22:23
@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Mar 25, 2025
@juliusknorr juliusknorr force-pushed the fix/filter-empty-email branch from 049825a to f3c8e9a Compare March 25, 2025 22:35
@juliusknorr juliusknorr force-pushed the fix/filter-empty-email branch from f3c8e9a to 87e1288 Compare March 25, 2025 22:35
@juliusknorr
Copy link
Member Author

Using filter_var now as per feedback from @blizzz

@juliusknorr
Copy link
Member Author

/backport! to stable31

@juliusknorr
Copy link
Member Author

/backport! to stable30

@juliusknorr
Copy link
Member Author

/backport! to stable29

1 similar comment
@Pytal
Copy link
Member

Pytal commented Mar 25, 2025

/backport! to stable29

@backportbot
Copy link

backportbot bot commented Mar 25, 2025

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/51707/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 87e12884

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51707/stable29

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/51707/stable29."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@AndyScherzinger AndyScherzinger added this to the Nextcloud 32 milestone Mar 25, 2025
@juliusknorr juliusknorr force-pushed the fix/filter-empty-email branch from 1cd0b07 to e3df2a9 Compare March 26, 2025 10:25
…etion

Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the fix/filter-empty-email branch from e3df2a9 to 46f531a Compare March 26, 2025 10:51
@AndyScherzinger AndyScherzinger merged commit d2773cf into master Mar 27, 2025
201 of 206 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/filter-empty-email branch March 27, 2025 23:14
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants