-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: filter out contacts with empty email addresses in sharee completion #51707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
049825a to
f3c8e9a
Compare
f3c8e9a to
87e1288
Compare
|
Using filter_var now as per feedback from @blizzz |
|
/backport! to stable31 |
|
/backport! to stable30 |
|
/backport! to stable29 |
1 similar comment
|
/backport! to stable29 |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/51707/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 87e12884
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51707/stable29Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/51707/stable29."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
1cd0b07 to
e3df2a9
Compare
…etion Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Julius Knorr <jus@bitgrid.net>
e3df2a9 to
46f531a
Compare
Otherwise contacts without an email address would still show up when sharing or adding them to a circle, which is not possible as there is no destination to share to