Skip to content

[stable29] fix(css): ensure header title is readable with dark background #51599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

[stable29] fix(css): ensure header title is readable with dark background #51599

merged 1 commit into from
Mar 21, 2025

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Mar 20, 2025 •
edited
Loading

Summary

To reproduce:

  1. set background image to a very dark one
  2. set primary color to white
  3. this causes primary text color to be black
  4. see black text on black background image

Screenshots

before after
Bildschirmfoto am 2025-03-20 um 15 27 46 Bildschirmfoto am 2025-03-20 um 15 27 50

Checklist

@susnux
fix(css): ensure header title is readable with dark background
af55ec8 
To reproduce:
1. set background image to a very dark one
2. set primary color to white
3. this causes primary text color to be black
4. see black text on black background image

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Mar 20, 2025
@susnux susnux added this to the Nextcloud 29.0.15 milestone Mar 20, 2025
@susnux susnux requested review from a team, Pytal, nfebe, sorbaugh and szaimen and removed request for a team and sorbaugh March 20, 2025 14:33
@susnux
Copy link
Contributor Author

susnux commented Mar 20, 2025

31 and 30 are not affected.

@susnux susnux mentioned this pull request Mar 20, 2025
Closed
@susnux susnux linked an issue Mar 20, 2025 that may be closed by this pull request
[Bug]: 29 - header title on public shares can be hard to read #51597
Closed
8 tasks
@susnux susnux changed the title fix(css): ensure header title is readable with dark background [stable29] fix(css): ensure header title is readable with dark background Mar 20, 2025
szaimen
szaimen approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but did not test

@susnux susnux merged commit ebefd60 into stable29 Mar 21, 2025
114 checks passed
@susnux susnux deleted the fix/stable29-header-title branch March 21, 2025 00:02
@Altahrim Altahrim mentioned this pull request Apr 3, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 29.0.15

Development

Successfully merging this pull request may close these issues.

[Bug]: 29 - header title on public shares can be hard to read

4 participants

@susnux @Pytal @szaimen