Skip to content

fix(database): Cast users count to integer #51490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

fix(database): Cast users count to integer #51490

merged 1 commit into from
Mar 25, 2025

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Mar 14, 2025 •
edited
Loading

int is required since #50171

Checklist

@solracsf solracsf requested a review from come-nc March 14, 2025 15:08
@solracsf solracsf force-pushed the castUsersCountToInt branch from 6b05456 to 2d0e196 Compare March 14, 2025 15:18
@solracsf solracsf marked this pull request as ready for review March 14, 2025 15:56
@solracsf solracsf requested a review from a team as a code owner March 14, 2025 15:56
@solracsf solracsf requested review from icewind1991 and nfebe and removed request for a team March 14, 2025 15:56
@solracsf solracsf added bug 3. to review Waiting for reviews feature: database Database related DB labels Mar 14, 2025
@solracsf
Copy link
Member Author

/backport to stable31

@solracsf solracsf added this to the Nextcloud 32 milestone Mar 14, 2025
kesselb
kesselb approved these changes Mar 15, 2025
View reviewed changes
Copy link
Collaborator

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@come-nc
Copy link
Contributor

come-nc commented Mar 17, 2025

We should also add a test for the method

@solracsf @susnux
fix(database): Cast users count to integer
18de9be 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@susnux susnux force-pushed the castUsersCountToInt branch from 2d0e196 to 18de9be Compare March 20, 2025 11:01
@skjnldsv skjnldsv merged commit 248d21a into master Mar 25, 2025
227 of 237 checks passed
@skjnldsv skjnldsv deleted the castUsersCountToInt branch March 25, 2025 11:57
@backportbot backportbot bot mentioned this pull request Mar 25, 2025
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselb kesselb kesselb approved these changes

@come-nc come-nc come-nc approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: database Database related DB

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[Bug]: 31.0.1 cannot access settings overview and users, wrong type returned in countUsers() function

5 participants

@solracsf @come-nc @kesselb @skjnldsv