Skip to content

Conversation

@hendrikheil
Copy link
Contributor

@hendrikheil hendrikheil commented Mar 12, 2025

Summary

We just worked with Nextcloud webhooks. We noticed that the OpenAPI specification defines the authMethod which uses headers for authentication as headers. This seems to be a typo in both the OpenAPI spec as well as the docblocks inside the code itself. The AuthMethod enum itself defines the cases Header and None, which map to header (singular) and none respectively.

Checklist

@hendrikheil hendrikheil requested review from a team and provokateurin as code owners March 12, 2025 19:29
@hendrikheil hendrikheil requested review from ArtificialOwl and skjnldsv and removed request for a team March 12, 2025 19:29
Signed-off-by: Hendrik Heil <hendrik@heil.sh>
@hendrikheil hendrikheil changed the title fix: resolve typo in authMode enum cases fix: resolve typo in authMethod enum cases Mar 12, 2025
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this is wrong!

@provokateurin provokateurin requested a review from come-nc March 12, 2025 19:50
@provokateurin
Copy link
Member

/backport to stable31

@provokateurin
Copy link
Member

/backport to stable30

@provokateurin
Copy link
Member

/backport to stable29

@ChristophWurst ChristophWurst added bug 4. to release Ready to be released and/or waiting for tests to finish labels Mar 13, 2025
@provokateurin
Copy link
Member

@hendrikheil You need to run ./build/openapi-checker.sh and amend the result to the commit.

Signed-off-by: Hendrik Heil <hendrik@heil.sh>
@come-nc
Copy link
Contributor

come-nc commented Mar 17, 2025

This needs a force-merge as it comes from a fork.

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@sorbaugh sorbaugh disabled auto-merge March 27, 2025 13:24
@sorbaugh sorbaugh merged commit c359e62 into nextcloud:master Mar 27, 2025
175 of 180 checks passed
@welcome
Copy link

welcome bot commented Mar 27, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@backportbot
Copy link

backportbot bot commented Mar 27, 2025

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/51449/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 90872660 7ac3fa7e

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51449/stable29

Error: Failed to check for changes with origin/stable29: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@provokateurin
Copy link
Member

Backport to 29 was wrong because the app was only added in 30 :)

@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish backport-request bug feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants