-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: resolve typo in authMethod enum cases #51449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve typo in authMethod enum cases #51449
Conversation
Signed-off-by: Hendrik Heil <hendrik@heil.sh>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this is wrong!
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
|
@hendrikheil You need to run |
Signed-off-by: Hendrik Heil <hendrik@heil.sh>
|
This needs a force-merge as it comes from a fork. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/51449/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 90872660 7ac3fa7e
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51449/stable29Error: Failed to check for changes with origin/stable29: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
Backport to 29 was wrong because the app was only added in 30 :) |
Summary
We just worked with Nextcloud webhooks. We noticed that the OpenAPI specification defines the
authMethodwhich uses headers for authentication asheaders. This seems to be a typo in both the OpenAPI spec as well as the docblocks inside the code itself. TheAuthMethodenum itself defines the casesHeaderandNone, which map toheader(singular) andnonerespectively.Checklist