Skip to content

Conversation

@peleroux
Copy link

  • Resolves: #

Summary

Hello, with the release 31.0.0 of nextcloud, we got a 404 error while downloading multiple files in a zip archive from a directory containing the ':' character in its name. It seems to be related to the function "downloadNodes". The url.pathname is computed using node.source and later it is used to compute the path of files that uses node.encodedSource.
When the ':' character is present in the string, this causes a wrong substring computation of the file name.

TODO

  • ...

Checklist

@peleroux peleroux requested review from a team and skjnldsv as code owners March 12, 2025 15:11
@peleroux peleroux requested review from sorbaugh and susnux and removed request for a team March 12, 2025 15:11
@peleroux peleroux changed the title Master Fix download multiple files path Mar 12, 2025
@susnux susnux added this to the Nextcloud 32 milestone Mar 12, 2025
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@skjnldsv
Copy link
Member

I think this got fixed by #51684

@skjnldsv skjnldsv closed this Mar 27, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants