Skip to content

fix(RichObjectStrings): Make exception messages for invalid parameters more useful for debugging #51442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

fix(RichObjectStrings): Make exception messages for invalid parameters more useful for debugging #51442

merged 1 commit into from
Mar 12, 2025

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Mar 12, 2025 •
edited
Loading

Summary

Makes it easier to figure what exactly is wrong, given that only the value was currently logged and this was not enough to properly debug it even with an available stacktrace.

Checklist

@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Mar 12, 2025
@provokateurin provokateurin added this to the Nextcloud 32 milestone Mar 12, 2025
@provokateurin provokateurin requested a review from a team as a code owner March 12, 2025 13:44
@provokateurin provokateurin requested review from Altahrim, icewind1991 and yemkareems and removed request for a team March 12, 2025 13:44
@provokateurin
Copy link
Member Author

/backport to stable31

@provokateurin provokateurin force-pushed the fix/rich-object-strings/better-exception-messages branch from 71f8c4d to b1b21bf Compare March 12, 2025 13:49
@provokateurin
fix(RichObjectStrings): Make exception messages for invalid parameter…
3c698c6 
…s more useful for debugging

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the fix/rich-object-strings/better-exception-messages branch from b1b21bf to 3c698c6 Compare March 12, 2025 13:52
susnux
susnux approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@provokateurin provokateurin enabled auto-merge March 12, 2025 14:05
@provokateurin provokateurin mentioned this pull request Mar 12, 2025
Closed
8 tasks
@provokateurin provokateurin merged commit 535799c into master Mar 12, 2025
190 checks passed
@provokateurin provokateurin deleted the fix/rich-object-strings/better-exception-messages branch March 12, 2025 15:16
@backportbot backportbot bot mentioned this pull request Mar 12, 2025
Merged
This was referenced Apr 7, 2025
Merged
Closed
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@susnux susnux susnux approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@provokateurin @nickvergessen @susnux @skjnldsv