- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 4.6k
fix(settings): Fix infinitely loading account management page with pagination of groups #51336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    93936f1    to
    bc2d292      
    Compare
  
    
              
                    come-nc
  
              
              reviewed
              
                  
                    Mar 20, 2025 
                  
              
              
            
            
      
        
              This comment was marked as resolved.
        
        
      
    
  This comment was marked as resolved.
Signed-off-by: Christopher Ng <chrng8@gmail.com>
4a01a06    to
    1d0ae0c      
    Compare
  
    | /compile | 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
| /backport to stable31 | 
| /backport to stable30 | 
      
        
      
      
  
    2 tasks
  
      
        
      
      
  
    2 tasks
  
| /backport to stable30 | 
      
        
              This comment was marked as resolved.
        
        
      
    
  This comment was marked as resolved.
      
        
              This comment was marked as off-topic.
        
        
      
    
  This comment was marked as off-topic.
      
        
      
      
  
    8 tasks
  
| This PR is causing issues in groups display names: #52130 | 
| @solracsf please do it the other way around and mention the PR in the issue and avoid bumping merged PRs. | 
      
        
      
      
  
    8 tasks
  
      
        
      
      
  
    8 tasks
  
      
     Merged
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Summary
With a large number of groups, e.g. >=10,000, the compute load on the server and client becomes excessive. On the server all groups are pre-computed in-memory resulting in increased response latency and excessive payload size. As a result the page loads indefinitely and becomes unresponsive.
To Do
Checklist