Skip to content

fix(dav): Handle long absence status earlier #51256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

fix(dav): Handle long absence status earlier #51256

merged 1 commit into from
Mar 5, 2025

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Mar 5, 2025 •
edited
Loading

  • Resolves: #

Summary

Validate the request early. Don't let this cause a database error.

TODO

  • Do

Checklist

@ChristophWurst ChristophWurst self-assigned this Mar 5, 2025
@ChristophWurst ChristophWurst requested review from a team and provokateurin as code owners March 5, 2025 07:13
@ChristophWurst ChristophWurst requested review from artonge and skjnldsv and removed request for a team March 5, 2025 07:13
@ChristophWurst
Copy link
Member Author

/backport to stable31

@ChristophWurst
Copy link
Member Author

/backport to stable30

@ChristophWurst
Copy link
Member Author

/backport to stable29

@ChristophWurst
Copy link
Member Author

/backport to stable28

@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Mar 5, 2025
st3iny
st3iny approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@st3iny
Copy link
Member

st3iny commented Mar 5, 2025

Complaints by php-cs are legit though.

@ChristophWurst
fix(dav): Handle long absence status earlier
c91dee7 
Validate the request early. Don't let this cause a database error.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the fix/dav/absence-status-too-long branch from c891bde to c91dee7 Compare March 5, 2025 08:43
@ChristophWurst ChristophWurst mentioned this pull request Mar 5, 2025
Merged
3 tasks
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 5, 2025
@ChristophWurst ChristophWurst merged commit b9a166a into master Mar 5, 2025
189 of 190 checks passed
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Mar 5, 2025
@ChristophWurst ChristophWurst deleted the fix/dav/absence-status-too-long branch March 5, 2025 09:59
This was referenced Mar 5, 2025
Merged
Merged
Merged
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@st3iny st3iny st3iny approved these changes

@kesselb kesselb kesselb approved these changes

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-backend

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner automatically assigned from nextcloud/server-backend

Assignees

@ChristophWurst ChristophWurst

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: dav

Projects

💌 📅 👥 Groupware team
Status: ☑️ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ChristophWurst @st3iny @nickvergessen @kesselb