[30][wip] reduce memory usage for fetching cached mount into #51075
+100
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
fetch-mount-memory-30
branch
from
5baab5c to
98f1214
Compare
icewind1991
force-pushed
the
fetch-mount-memory-30
branch
from
98f1214 to
31114a6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $result[$mount->getUser()->getUID()] = $userFolder->getById($id); | ||
| foreach ($mounts as $cachedMount) { | ||
| $mount = $this->rootFolder->getMount($cachedMount->getMountPoint()); | ||
| $cache = $mount->getStorage()->getCache(); |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
| $mount = $this->rootFolder->getMount($cachedMount->getMountPoint()); | ||
| $cache = $mount->getStorage()->getCache(); | ||
| $cacheEntry = $cache->get($id); | ||
| $node = $this->rootFolder->getNodeFromCacheEntryAndMount($cacheEntry, $mount); |
Check notice
Code scanning / Psalm
PossiblyFalseArgument Note
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
fetch-mount-memory-30
branch
from
31114a6 to
48dc7ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 #51074