Skip to content

perf(files): faster query to fetch incomplete directories #50781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

perf(files): faster query to fetch incomplete directories #50781

merged 1 commit into from
Feb 13, 2025

Conversation

@Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Feb 12, 2025 •
edited
Loading

Summary

Using equality instead of lower than should help MySQL like to use the right index.

Checklist

@Altahrim Altahrim self-assigned this Feb 12, 2025
@Altahrim Altahrim force-pushed the perf/improve-incomplete-scan branch from f275d0b to dcedd4d Compare February 12, 2025 14:59
@Altahrim Altahrim added this to the Nextcloud 32 milestone Feb 12, 2025
@Altahrim Altahrim force-pushed the perf/improve-incomplete-scan branch 2 times, most recently from 465a656 to 8f85cd9 Compare February 12, 2025 15:47
ChristophWurst
ChristophWurst approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a small production instance and mariadb executes the query efficiently 👍

@Altahrim Altahrim force-pushed the perf/improve-incomplete-scan branch from 8f85cd9 to 3995ca3 Compare February 13, 2025 08:48
@Altahrim
perf(files): faster query to fetch incomplete directories
9bdee76 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim Altahrim force-pushed the perf/improve-incomplete-scan branch from 3995ca3 to 9bdee76 Compare February 13, 2025 09:11
@Altahrim Altahrim marked this pull request as ready for review February 13, 2025 09:35
@Altahrim Altahrim added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 13, 2025
@Altahrim
Copy link
Collaborator Author

/backport to stable31

@Altahrim
Copy link
Collaborator Author

/backport to stable30

@Altahrim
Copy link
Collaborator Author

/backport to stable29

@Altahrim Altahrim mentioned this pull request Feb 13, 2025
Merged
5 tasks
artonge
artonge approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Altahrim Altahrim removed the 3. to review Waiting for reviews label Feb 13, 2025
@Altahrim Altahrim merged commit c71bc06 into master Feb 13, 2025
193 checks passed
@Altahrim Altahrim deleted the perf/improve-incomplete-scan branch February 13, 2025 14:21
This was referenced Feb 13, 2025
Merged
Merged
Merged
@icewind1991 icewind1991 mentioned this pull request May 26, 2025
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@artonge artonge artonge approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@Altahrim Altahrim

Labels

performance 🚀

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@Altahrim @ChristophWurst @artonge @skjnldsv