perf(cron): Delay (re)checking timed jobs

[ChristophWurst]

• Resolves: #

Summary

Right now timed jobs are always loaded from the db and instantiated. Jobs with intervals higher than the cron interval are continuously loaded and checked, \OCP\BackgroundJob\TimedJob::start prevents the actual execution.
As an optimization we can preemptively check if a job is ready. Otherwise we park it for a later check.

How to test

1. Set breakpoints in timed jobs constructors
2. Observe how the jobs are instantiated once for the initial check and only every instantiated again when they are ready or two days have passed.

TODO

• Make the changes
• Manually test the changes
  • Jobs that are ready are executed like before
  • Jobs are parked as expected
  • Once the parked timestamp elapsed, jobs run again like before

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[marcelklehr]

Tests might be nice for this, and it's not hard, the test infra for bg jobs is quite nice, imho: https://github.com/nextcloud/server/blob/master/tests/lib/BackgroundJob/JobListTest.php

[marcelklehr]

Do you have more details on why the 48 hours?

[ChristophWurst]

I was thinking that someone might set a (dynamic) interval that is too high so that a job is never checked again. This gives the job a chance to recover.
For any jobs that run rarely (like every two weeks) and disabled apps, that would also help clear up the row earlier.

[come-nc]

Is it not possible to add a condition on lastrun+interval as part of the SQL query instead?

[ChristophWurst]

Is it not possible to add a condition on lastrun+interval as part of the SQL query instead?

interval only exists in memory of the PHP process and is not materialized to the oc_jobs table.

^ I can't tell which rows represent a timed job, neither do I know the interval.

[ChristophWurst]

/backport to stable31