Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(occ): hide sensitive data while config:app:set #49826

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

printminion-co
Copy link
Contributor

Summary

Do not display sensitive values in CLI output.

Before:

./occ config:app:set --value "secret!" --sensitive --type string my_app my_secret_pass        

⚠️ my pass is visible in output as plain text

Config value 'my_secret_pass' for app 'my_app' is now set to 'secret!', stored as string in fast cache

After:

./occ config:app:set --value "secret!" --sensitive --type string my_app my_secret_pass             

☑️ my pass is displayed as <sensitive>

Config value 'my_secret_pass' for app 'my_app' is now set to '<sensitive>', stored as string in fast cache

TODO

  • ...

Checklist

@printminion-co printminion-co force-pushed the fix/occ_hide_sensitive_values branch 2 times, most recently from e2a5242 to b1b1c1b Compare December 19, 2024 12:00
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

in order to hide sensitive data from logs

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
@printminion-co printminion-co force-pushed the fix/occ_hide_sensitive_values branch from b1b1c1b to aac9b15 Compare January 6, 2025 08:59
@come-nc come-nc added enhancement 4. to release Ready to be released and/or waiting for tests to finish feature: occ labels Jan 7, 2025
@come-nc come-nc added this to the Nextcloud 31 milestone Jan 7, 2025
@blizzz blizzz mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: occ feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants