fix(oauth): instance name encoding on oauth app in admin #49804

byt3sage · 2024-12-11T19:29:23Z

Resolves: [Bug]: Instance name not decoded in the "OAuth 2.0-Clients" config menu #39956

Summary

This PR aims to resolve the issue with the encoding of the instance name when shown in the OAuth settings in Nextcloud admin.
This is my first PR for Nextcloud (and hopefully the first of many) so I'm keen for any feedback if this approach doesn't follow what it should.
I've removed instance name from the translate function. My reasoning for this is the instance name will already be in the users own language and this avoids the issue of the translate function escaping special characters.

TODO

Remove instance name binding from the translate function and use string interpolation instead.
Update translation files to ensure the string prior to the instance name is still translated.

Screenshots

Before

After

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

…decoding Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: byt3sage <jjt@tfmail.co.uk>

kesselb · 2024-12-12T18:29:35Z

Thanks for your pull request 👍

Please revert the changes to the language files. The files are synced automatically from Transifex. It's enough to change the source.

byt3sage · 2024-12-13T09:13:06Z

@kesselb Ah that makes sense! I've reverted these back now.

…stance-name-decoding-39956

…yt3sage/server into bug/oauth-instance-name-decoding-39956

…yt3sage/server into bug/oauth-instance-name-decoding-39956 Signed-off-by: byt3sage <jjt@tfmail.co.uk>

…yt3sage/server into bug/oauth-instance-name-decoding-39956

Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: Robin Appelman <robin@icewind.nl> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: nfebe <fenn25.fn@gmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: grnd-alt <salimbelakkaf@outlook.de> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: grnd-alt <github@belakkaf.net> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

…ric one Let the controller access the HintException and show the error to the user. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

This fixes a regression that bad password returned 403 instead of 400 because of previous changes. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

…lete requests Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: Christopher Ng <chrng8@gmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

…lumns Signed-off-by: Robin Appelman <robin@icewind.nl> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

…oned queries Signed-off-by: Robin Appelman <robin@icewind.nl> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.7...3.3.8) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

…yt3sage/server into bug/oauth-instance-name-decoding-39956

github-actions · 2024-12-26T01:58:09Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

kesselb · 2024-12-27T15:35:43Z

cc @julien-nc

kesselb · 2024-12-27T15:36:28Z

Hi @byt3sage

Thank you, it appears that the last rebase went wrong. Could you please retry?

byt3sage added 2 commits December 11, 2024 19:22

bug: moved instance name out of l10n to fix issue with instance name …

02a6eb4

…decoding Signed-off-by: byt3sage <jjt@tfmail.co.uk>

chore: formatting

91a399e

Signed-off-by: byt3sage <jjt@tfmail.co.uk>

byt3sage mentioned this pull request Dec 11, 2024

[Bug]: Instance name not decoded in the "OAuth 2.0-Clients" config menu #39956

Open

8 tasks

Merge branch 'master' into bug/oauth-instance-name-decoding-39956

5321597

chore: reverted language files

cfafc3c

byt3sage and others added 23 commits December 13, 2024 09:14

Merge branch 'master' of github.com:byt3sage/server into bug/oauth-in…

4c57f0b

…stance-name-decoding-39956

Merge branch 'bug/oauth-instance-name-decoding-39956' of github.com:b…

8bfe048

…yt3sage/server into bug/oauth-instance-name-decoding-39956

Merge branch 'master' into bug/oauth-instance-name-decoding-39956

ce6e450

Merge branch 'bug/oauth-instance-name-decoding-39956' of github.com:b…

4cd8a48

…yt3sage/server into bug/oauth-instance-name-decoding-39956 Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Merge branch 'bug/oauth-instance-name-decoding-39956' of github.com:b…

7a9eb28

…yt3sage/server into bug/oauth-instance-name-decoding-39956

chore: formatting

d766b71

Signed-off-by: byt3sage <jjt@tfmail.co.uk>

chore: reverted language files

f259cbc

Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix: Fix ServiceWorker scope when Nextcloud installed in subfolder

4f8eec1

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

chore(assets): Recompile assets

6ce16a9

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

chore: cleanup leftover debug statement

f4993a6

Signed-off-by: Robin Appelman <robin@icewind.nl> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix(files): throttle favorite with max 5 simultaneous requests

ab6bd5e

Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

chore(assets): Recompile assets

7d2508a

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix(files_sharing): Correct property enforced property names

810a5bc

Signed-off-by: nfebe <fenn25.fn@gmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

chore(assets): Recompile assets

1ac6a3a

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Fix(l10n): Update translations from Transifex

f37a39c

Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix(files_sharing): also submit new share on password submit

0f464f8

Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

chore(assets): Recompile assets

9687bb8

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix(dav): add activity logging for favorites in dav

1690451

Signed-off-by: grnd-alt <salimbelakkaf@outlook.de> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

refactor(tags): move favorite event dispatching to tags.php

9e18dbd

Signed-off-by: grnd-alt <salimbelakkaf@outlook.de> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix(tests): remove redundant unit test for activity

0443c66

Signed-off-by: grnd-alt <github@belakkaf.net> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix(files_sharing): Do not wrap password policy exception into a gene…

931eb36

…ric one Let the controller access the HintException and show the error to the user. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix(shares): Wrap exceptions from password validation to set code to 400

a230b74

This fixes a regression that bad password returned 403 instead of 400 because of previous changes. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix(tests): Adapt ManagerTest to change in Exception class used

fe8c429

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

skjnldsv and others added 14 commits December 13, 2024 09:19

feat(files_trashbin): add cypress tests

8f01172

Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

perf(files_trashbin): use empty trashbin endpoint instead of batch de…

89d71d7

…lete requests Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

feat(files_trashbin): improve wordings

6790fe7

Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix(trashbin): Fix infinitely loading empty trash action on close

c77f57f

Signed-off-by: Christopher Ng <chrng8@gmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

chore: compile assets

b73b62c

Signed-off-by: Christopher Ng <chrng8@gmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

chore(psalm): Update baseline

53905e7

Signed-off-by: Christopher Ng <chrng8@gmail.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix: handle calling select on partitioned queries with an array of co…

a6e54da

…lumns Signed-off-by: Robin Appelman <robin@icewind.nl> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

fix: improve logic for ensuring join columns are selected for partiti…

0a58000

…oned queries Signed-off-by: Robin Appelman <robin@icewind.nl> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

feat(dashboard): wish happy birthday

a37e715

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

chore(assets): Recompile assets

9eb8ab4

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Fix(l10n): Update translations from Transifex

0c49e36

Signed-off-by: Nextcloud bot <bot@nextcloud.com> Signed-off-by: byt3sage <jjt@tfmail.co.uk>

Merge branch 'bug/oauth-instance-name-decoding-39956' of github.com:b…

77ca4f5

…yt3sage/server into bug/oauth-instance-name-decoding-39956

Merge branch 'master' into bug/oauth-instance-name-decoding-39956

c9ffff9

github-actions bot added the feedback-requested label Dec 26, 2024

susnux added this to the Nextcloud 32 milestone Mar 2, 2025

This was referenced Aug 22, 2025

32.0.0 beta 2 #54581

Merged

32.0.0 beta 3 #54606

Merged

32.0.0 beta 4 #54688

Merged

This was referenced Sep 2, 2025

32.0.0 beta 5 #54796

Merged

[stable32] 32.0.0 RC1 #54864

Merged

nextcloud-bot mentioned this pull request Sep 10, 2025

[stable32] 32.0.0 RC2 #55000

Merged

nextcloud-bot mentioned this pull request Sep 18, 2025

[stable32] 32.0.0 RC3 #55162

Merged

This was referenced Sep 25, 2025

[stable32] 32.0.0 RC4 #55298

Merged

[stable32] 32.0.0 #55354

Merged

skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(oauth): instance name encoding on oauth app in admin #49804

fix(oauth): instance name encoding on oauth app in admin #49804

byt3sage commented Dec 11, 2024

Uh oh!

kesselb commented Dec 12, 2024

Uh oh!

byt3sage commented Dec 13, 2024

Uh oh!

github-actions bot commented Dec 26, 2024

Uh oh!

kesselb commented Dec 27, 2024

Uh oh!

kesselb commented Dec 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

fix(oauth): instance name encoding on oauth app in admin #49804

Are you sure you want to change the base?

fix(oauth): instance name encoding on oauth app in admin #49804

Conversation

byt3sage commented Dec 11, 2024

Summary

TODO

Screenshots

Checklist

Uh oh!

kesselb commented Dec 12, 2024

Uh oh!

byt3sage commented Dec 13, 2024

Uh oh!

github-actions bot commented Dec 26, 2024

Uh oh!

kesselb commented Dec 27, 2024

Uh oh!

kesselb commented Dec 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants