fix(user_ldap): retrieve from LDAP first "email shaped" value instead of first value

[Thatoo]

retrieve from LDAP first "email shaped" value instead of first value

• Resolves: # [Bug]: LDAP Advance > Special attributes > email field should take first "email shaped" value, not first value of LDAP answer. #49177

Summary

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[Thatoo]

Thank you @solracsf .
Would you mind translate me what these checking error mean and what I can do to solve them?

[come-nc]

It makes sense, it seems the User class is not doing any additional check on the email address being set.

[come-nc]

See https://www.conventionalcommits.org/en/v1.0.0/ for conventional commits ref.
For cypress and performance I think they always fail on PR from forks.

What I’m wondering is whether it would not make sense to instead import all values as email addresses into the profile, as there can be multiple in there, and log a warning when a value is not a valid email address.
I fail to see what the usecase is for a field where only some values are set as email address, can you enlighten me @Thatoo ?

[Thatoo]

I'll check your link about conventional commits ref.

It is indeed a good idea to retrieve all email shaped values instead of only the first one but I'm not sure how to do so then.

I fail to see what the usecase is for a field where only some values are set as email address, can you enlighten me @Thatoo ?

Well, I can take the example that lead me to this PR : In Yunohost LDAP, the first value of the LDAP forward mail category corresponds to the user's name, because the aim, when an e-mail is sent to camille@domaine.tld, is to actually deliver this e-mail to camille (without @domaine.tld), which corresponds to the local user, i.e. the yunohost mailbox, and also to the forward address. So all values from the second value have an email shaped value but not the first one. That's how the idea of this PR came to my mind.

[Thatoo]

I created this new PR to answer the conventional commits ref issue of my first (this) PR.
#49404

If it is ok, then we can close this one I guess.

[solracsf]

Well, you could just ammend this PR, not create a new one... 😿

[Thatoo]

I didn't find how to modify a commit in Github. I didn't want to clone this repo into my computer for so little and meaningless change (just satisfying a normative way of writing) as this repo is very massive (big download = carbon impact).
Three ways were then possible :

• accepting the PR with no normative way of writing but I didn't have the will to argue on that, we (human) get used to bend in front of fatality of computing (companies and states are slaving us a little more everyday to obey and fit the cell/box).
• github would have offer a quick way for me to obey and rewrite my commit.
• open a new PR and close this one : much easier, faster, less carbon impacting and I could do that freely so that's why I choose to do so.

[come-nc]

I didn't find how to modify a commit in Github. I didn't want to clone this repo into my computer for so little and meaningless change (just satisfying a normative way of writing) as this repo is very massive (big download = carbon impact). Three ways were then possible :

• accepting the PR with no normative way of writing but I didn't have the will to argue on that, we (human) get used to bend in front of fatality of computing (companies and states are slaving us a little more everyday to obey and fit the cell/box).
• github would have offer a quick way for me to obey and rewrite my commit.
• open a new PR and close this one : much easier, faster, less carbon impacting and I could do that freely so that's why I choose to do so.

I missed that this PR was open through github UI, you cannot force-push in this case?

[Thatoo]

I don't think so, never find how.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)