fix(files): Properly reset all file list filters on view change #49261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
a team,
artonge,
Pytal and
szaimen
and removed request for
a team
|
/backport to stable30 |
nfebe
approved these changes
Nov 19, 2024
susnux
force-pushed
the
fix/file-list-filters-reset
branch
from
cb5c499 to
82e6814
Compare
|
/compile |
susnux
force-pushed
the
fix/file-list-filters-reset
branch
3 times, most recently
from
1f76148 to
3ff1c10
Compare
Replace the mixin with a composable, this is better typed and works in both: Options- and Composition API. Also added component tests for it. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/file-list-filters-reset
branch
from
3ff1c10 to
9d80a7e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure that by design all file list filters are reset on view change.
This is now implemented in the interface rather than manually listening to event by every filter.
Also refactored the filters store to store-setup style as this allows to run an init function.
Checklist