Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(profile): move profile app from core to apps #49244

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

skjnldsv
Copy link
Member

Fix #29323

Cleanup core a bit more

@skjnldsv skjnldsv added 3. to review Waiting for reviews technical debt feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Nov 13, 2024
@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Nov 13, 2024
@skjnldsv skjnldsv self-assigned this Nov 13, 2024
@skjnldsv skjnldsv force-pushed the feat/profile-app branch 3 times, most recently from 6a22f01 to c9b63d8 Compare November 13, 2024 09:34
@provokateurin

This comment was marked as resolved.

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the versions need to be adjusted

apps/profile/appinfo/info.xml Outdated Show resolved Hide resolved
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 14, 2024
@provokateurin provokateurin merged commit 9576624 into master Nov 14, 2024
186 checks passed
@provokateurin provokateurin deleted the feat/profile-app branch November 14, 2024 10:07
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider moving Profile into dedicated app
4 participants