-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(profile): move profile app from core to apps #49244
Merged
Merged
+1,268
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
3. to review
Waiting for reviews
technical debt
feature: profile
PRs or issues related to the Profile feature (e.g. Profile page, API, etc.)
labels
Nov 13, 2024
skjnldsv
requested review from
hamza221 and
SebastianKrupinski
as code owners
November 13, 2024 08:58
skjnldsv
force-pushed
the
feat/profile-app
branch
3 times, most recently
from
November 13, 2024 09:34
6a22f01
to
c9b63d8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
force-pushed
the
feat/profile-app
branch
from
November 13, 2024 10:38
b078415
to
c83acf2
Compare
provokateurin
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just the versions need to be adjusted
skjnldsv
force-pushed
the
feat/profile-app
branch
from
November 13, 2024 12:02
c83acf2
to
a0aaaf2
Compare
provokateurin
approved these changes
Nov 13, 2024
susnux
reviewed
Nov 13, 2024
susnux
reviewed
Nov 13, 2024
skjnldsv
force-pushed
the
feat/profile-app
branch
from
November 13, 2024 18:51
d9909aa
to
6201982
Compare
come-nc
approved these changes
Nov 14, 2024
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
feat/profile-app
branch
from
November 14, 2024 09:27
6201982
to
5a98533
Compare
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Nov 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
feature: profile
PRs or issues related to the Profile feature (e.g. Profile page, API, etc.)
technical debt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #29323
Cleanup core a bit more