Skip to content

feat(files_sharing): use share node or label as page title#49142

Merged
skjnldsv merged 1 commit intomasterfrom
feat/sharing-title
Nov 8, 2024
Merged

feat(files_sharing): use share node or label as page title#49142
skjnldsv merged 1 commit intomasterfrom
feat/sharing-title

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 8, 2024

Fix #11506

image

@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Nov 8, 2024
@skjnldsv skjnldsv requested review from a team, jancborchardt and susnux November 8, 2024 07:58
@skjnldsv skjnldsv self-assigned this Nov 8, 2024
@skjnldsv skjnldsv requested review from artonge and szaimen and removed request for a team November 8, 2024 07:58
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 8, 2024
@skjnldsv skjnldsv merged commit d5caf91 into master Nov 8, 2024
@skjnldsv skjnldsv deleted the feat/sharing-title branch November 8, 2024 13:38
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skjnldsv thank you so much for fixing this btw @skjnldsv, it has been bugging me again recently, forgot about the open issue. :D

@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: files feature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Titles for share pages are not specific

4 participants