Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(core): fix app menu alignment in RTL mode. #49019

Merged

Conversation

falghamdi125
Copy link
Contributor

Summary

Hello,

This PR solves the app menu alignment in RTL mode.

Before:
image

After:
image

Checklist

@nickvergessen nickvergessen requested review from a team, skjnldsv, Pytal and szaimen and removed request for a team October 30, 2024 16:02
@nickvergessen nickvergessen added this to the Nextcloud 31 milestone Oct 30, 2024
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Oct 30, 2024
@szaimen szaimen removed their request for review October 30, 2024 16:31
@falghamdi125 falghamdi125 force-pushed the fix-appmenu-alignment-in-rtl-mode branch from 9b515c9 to 4c1bf5a Compare November 5, 2024 20:32
@skjnldsv skjnldsv requested a review from susnux November 6, 2024 07:47
Signed-off-by: Faisal Alghamdi <falghamdi125@gmail.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 9, 2024
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix-appmenu-alignment-in-rtl-mode branch from 4c1bf5a to e042443 Compare November 9, 2024 10:28
@skjnldsv skjnldsv merged commit 4a2091e into nextcloud:master Nov 9, 2024
103 of 106 checks passed
Copy link

welcome bot commented Nov 9, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@hamza221 hamza221 mentioned this pull request Dec 13, 2024
8 tasks
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: App menu alignment issue in RTL mode.
5 participants