Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Fix file names alignment in Files List in UI RTL mode. #49011

Merged

Conversation

falghamdi125
Copy link
Contributor

@falghamdi125 falghamdi125 commented Oct 30, 2024

Summary

This PR fixes the alignment of file names in RTL mode.

Before:
image

After:
image
The PR doesn't break non-RTL UI (English below)
image

Checklist

Review

@susnux

@susnux susnux force-pushed the fix-files-names-align-in-rtl branch from b55a67b to e646174 Compare November 5, 2024 17:18
Signed-off-by: Faisal Alghamdi <falghamdi125@gmail.com>
@skjnldsv skjnldsv force-pushed the fix-files-names-align-in-rtl branch from e646174 to 23a23ed Compare November 9, 2024 13:00
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 9, 2024
@skjnldsv skjnldsv merged commit 2c00f1e into nextcloud:master Nov 9, 2024
105 of 108 checks passed
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: File names incorrect alignment in UI RTL mode.
3 participants