Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Write memcache locking path hash to exception #48719

Closed
wants to merge 1 commit into from

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Oct 15, 2024

When trying to investigate stale locks it can be helpful to have the actual hash available for checking in redis. Otherwise one needs to manually construct the has from the storage and path.

Reference on the hashing:

$provider->acquireLock('files/' . md5($this->getId() . '::' . trim($path, '/')), $type, $this->getId() . '::' . $path);

Before:

"Documents/test.doc" is locked, existing lock on file: 2 shared lock

After:

"Documents/test.doc" is locked, existing lock on file: 2 shared lock: files/196106b5350a532ce3d8870cac8d466e

Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliushaertl juliushaertl requested review from a team, Altahrim, sorbaugh, come-nc and icewind1991 and removed request for a team October 15, 2024 15:35
@juliushaertl juliushaertl added bug 3. to review Waiting for reviews labels Oct 15, 2024
@juliushaertl
Copy link
Member Author

Sorry for the noise, I actually missed it is part of the previous exception message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant