Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files_sharing): Add proper user facing messages on success #48696

Merged
merged 2 commits into from
Oct 16, 2024
Merged

fix(files_sharing): Add proper user facing messages on success #48696

merged 2 commits into from
Oct 16, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 14, 2024 •
edited
Loading

Summary

  1. Use proper translated strings
  2. Fix invalid use of translation message on API result
  3. Log all errors

Checklist

@susnux susnux added this to the Nextcloud 31 milestone Oct 14, 2024
@susnux
Copy link
Contributor Author

susnux commented Oct 14, 2024

/backport to stable30

@susnux
Copy link
Contributor Author

susnux commented Oct 14, 2024

/backport to stable29

Pytal
Pytal approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix the message 👍

apps/files_sharing/src/mixins/SharesMixin.js Outdated Show resolved Hide resolved
@susnux susnux force-pushed the fix/share-notifications branch 2 times, most recently from ec4475c to e2c734d Compare October 15, 2024 23:19
@susnux
Copy link
Contributor Author

susnux commented Oct 15, 2024

/compile

@susnux susnux enabled auto-merge October 15, 2024 23:20
susnux and others added 2 commits October 16, 2024 12:09
@susnux @Pytal
fix(files_sharing): Add proper user facing messages on success
0ccced8 
1. Use proper translated strings
2. Fix invalid use of translation message on API result
3. Log all errors

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@nextcloud-command @susnux
chore(assets): Recompile assets
8e59960 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit 9692da4 into master Oct 16, 2024
118 checks passed
@susnux susnux deleted the fix/share-notifications branch October 16, 2024 10:49
This was referenced Oct 16, 2024
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansss Ivansss Ivansss approved these changes

@Pytal Pytal Pytal approved these changes

@solracsf solracsf Awaiting requested review from solracsf

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: sharing
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

[Bug]: Share confirmations messages wrong
4 participants
@susnux @Ivansss @Pytal @nextcloud-command