Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added type to createConnectionParams, removed safeguard #48666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Delogon
Copy link

@Delogon Delogon commented Oct 11, 2024

Summary

This should fix the db conversion bug. $type was added as a parameter to createConnectionParams in the ConnectionFactory.php. There is also a check if the type value is set if not the default is loaded from the config. There is also an additional type check to make sure mysql.utf8mb4 is only used with mysql. The parameters of createConnectionParams in Connection Factory has also been updated, and the safeguard has been removed. The solution was provided in the issue comments by @Queuecumber, @normen, @lightonflux and me.

TODO

Checklist

Signed-off-by: Nils Wenninghoff <nils@ungemein.cool>
@WhiskyDelta
Copy link

/backport to stable30

@WhiskyDelta
Copy link

/backport to stable29

@Delogon
Copy link
Author

Delogon commented Oct 12, 2024

@juliushaertl @joshtrichards cloud you review this? Or do you know who could?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: occ db:convert-type broken since PrimaryReadReplicaConnection support added
2 participants