-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gracefully parse non-standard trusted certificates #48307
fix: gracefully parse non-standard trusted certificates #48307
Conversation
7c02934
to
5b67d74
Compare
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
5b67d74
to
19ad135
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and new unit test seem to pass 😎
/backport to stable30 |
/backport to stable29 |
/backport to stable28 |
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/48307/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 19ad1357
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/48307/stable29 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/48307/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 19ad1357
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/48307/stable28 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
/backport to stable28 |
/backport to stable29 |
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/48307/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 19ad1357
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/48307/stable29 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/48307/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 19ad1357
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/48307/stable28 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
The format
-----BEGIN TRUSTED CERTIFICATE-----
is non-standard and only used by OpenSSL. However, they can still be parsed by PHP through OpenSSL if the separator strings are simply replaced.I also added a simple unit test with a sample certificate.
Checklist