Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appstoreFetcher): get list from a custom store and remove unnecessary warning #48114

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Sep 17, 2024

I might miss something or misunderstand what's happening here.

Summary

fix(appstoreFetcher): remove unneeded warning

Base get in Fetcher returns [] in 2 cases:

  1. Something went wrong, and the request failed — unexpected
    • In this case warning in AppFetcher is unnecessary, because it is already covered by base Fetcher:
      } catch (ConnectException $e) {
      $this->logger->warning('Could not connect to appstore: ' . $e->getMessage(), ['app' => 'appstoreFetcher']);
      return [];
  2. No app list should have been fetched (e.g. disabled)
    • In this case there should be no warning => removed to fix the linked issue

fix(appstoreFetcher): get app list from custom app store

Checklist

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug 2. developing Work in progress labels Sep 17, 2024
@ShGKme ShGKme added this to the Nextcloud 31 milestone Sep 17, 2024
@ShGKme ShGKme self-assigned this Sep 17, 2024
@skjnldsv skjnldsv merged commit 6f78730 into master Sep 17, 2024
174 checks passed
@skjnldsv skjnldsv deleted the fix/AppStore--remove-unneeded-warning branch September 17, 2024 08:26
@ShGKme
Copy link
Contributor Author

ShGKme commented Sep 17, 2024

/backport to stable30

@ShGKme
Copy link
Contributor Author

ShGKme commented Sep 17, 2024

/backport to stable29

Copy link

backportbot bot commented Sep 17, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/48114/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ce679c3d 70ed4aec

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/48114/stable29

Error: Failed to push branch backport/48114/stable29: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@ShGKme
Copy link
Contributor Author

ShGKme commented Sep 18, 2024

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: set 'appstoreenabled' => false, still show Warning logging
3 participants