fix(settings): disable Discover when appstore is disabled #48090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
requested review from
artonge and
skjnldsv
and removed request for
a team
|
/backport to stable30 |
|
/backport to stable30 |
|
/backport to stable29 |
susnux
reviewed
Sep 16, 2024
apps/settings/src/router/routes.ts
Outdated
| import { loadState } from '@nextcloud/initial-state' | ||
| import type { RouteConfig } from 'vue-router' |
There was a problem hiding this comment.
Types 🆙
Suggested change
| import { loadState } from '@nextcloud/initial-state' | |
| import type { RouteConfig } from 'vue-router' | |
| import type { RouteConfig } from 'vue-router' | |
| import { loadState } from '@nextcloud/initial-state' |
There was a problem hiding this comment.
ESLint does not complain ._.
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/settings--disable-discover-when-app-store-is-disabled
branch
from
2465ed0
to
5ac467b
Compare
nickvergessen
approved these changes
Sep 16, 2024
susnux
approved these changes
Sep 16, 2024
ShGKme
deleted the
fix/settings--disable-discover-when-app-store-is-disabled
branch
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Even when the App Store is disabled, the default page (also listed in the navigation) is Discovery, which doesn't work. And when there is no internet, it results in error: "Avertissement appstoreFetcher Could not get apps from the appstore".
Solution — if the app store is disabled:
P.S. It is still possible to open any category, including supported or non-existed by direct link and see an error. Might make sense to explicitly define the list of available categories and check before route enter/update.
Checklist