Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Restore missing dot in FilesListVirtual.vue #48003

Merged
merged 1 commit into from
Sep 15, 2024
Merged

fix: Restore missing dot in FilesListVirtual.vue #48003

merged 1 commit into from
Sep 15, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Sep 15, 2024

Follow up of #47920

@artonge
fix: Restore missing dot in FilesListVirtual.vue
699ce26 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge requested a review from skjnldsv as a code owner September 15, 2024 09:10
@artonge artonge requested a review from susnux September 15, 2024 09:10
@artonge artonge self-assigned this Sep 15, 2024
@artonge artonge added this to the Nextcloud 31 milestone Sep 15, 2024
@susnux susnux merged commit 01478f1 into master Sep 15, 2024
116 checks passed
@susnux susnux deleted the artonge/fix/missing_dot branch September 15, 2024 13:13
@skjnldsv
Copy link
Member

@susnux we are wondering how this was not caught by eslint.
We tried a bit with @artonge and we're not able to make it detect that error. I think this is quite an issue. Do you have any insight? :)

@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@susnux susnux susnux approved these changes

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews bug javascript
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
3 participants
@artonge @skjnldsv @susnux