Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable29] feat: Reset route if neither the Viewer of the Sidebar is open #48001

Merged
merged 2 commits into from
Sep 16, 2024
Merged

[stable29] feat: Reset route if neither the Viewer of the Sidebar is open #48001

merged 2 commits into from
Sep 16, 2024

Commits on Sep 16, 2024

  1. feat: Reset route if neither the Viewer of the Sidebar is open 

    When the viewer or the sidebar is opened, we add the fileid to the route.
When both of them are closed, we do not remove the fileid from the route.
This means that, upon reload, the sidebar will be opened even though it was closed previously.

This PR ensure that the fileid is removed from the route when both the Sidebar and the Viewer are closed.

Signed-off-by: Louis Chemineau <louis@chmn.me>
    @artonge
    artonge committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    936f34d View commit details
    Browse the repository at this point in the history

  2. chore: Compile assets 

    Signed-off-by: Louis Chemineau <louis@chmn.me>
    @artonge
    artonge committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    08c35a5 View commit details
    Browse the repository at this point in the history