fix: user:settings command when user is not available
#47889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `ignore-missing-user` all sub commands work, except listing all settings for a user like `occ user:settings --ignore-missing-user user core`. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
a team,
skjnldsv,
yemkareems and
come-nc
and removed request for
a team
|
/backport to stable30 |
skjnldsv
approved these changes
Sep 11, 2024
come-nc
reviewed
Sep 12, 2024
Comment on lines
+234
to
+237
| if ($user !== null || $ignoreMissingUser === false) { | ||
| // Only add the display name if the user exists (or is expected to exist) | ||
| $settings['settings']['display_name'] = $user?->getDisplayName(); | ||
| } |
There was a problem hiding this comment.
But simply changing for $user?-> would be enough, no?
All the rest of the PR is unnecessary to my understanding.
There was a problem hiding this comment.
This will wrongly output:
- core
- something: 1234
- settings
- display_name:
while with the current changes it correctly only lists the existing settings:
This will wrongly output:
- core
- something: 1234
There was a problem hiding this comment.
Then just using if ($user !== null) only would work? Why show the empty displayname when ignoreMissingUser is false?
skjnldsv
added
2. developing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If
ignore-missing-userall sub commands work, except listing all settings for a user likeocc user:settings --ignore-missing-user user core.Checklist