Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mailer): Call to custom mail_template_class #47435

Merged

Conversation

phreaker0
Copy link
Contributor

@phreaker0 phreaker0 commented Aug 22, 2024

Summary

In case of a custom mail_template_class the class is called with missing parameters (which were introduced in 29.0.5). This patch works for me.

Checklist

@solracsf solracsf changed the title fix call to custom mail_template_class fix(mailer): Call to custom mail_template_class Aug 22, 2024
@solracsf solracsf added the 3. to review Waiting for reviews label Aug 22, 2024
@solracsf solracsf added this to the Nextcloud 31 milestone Aug 22, 2024
@kesselb kesselb added the bug label Aug 22, 2024
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much 👍

@kesselb
Copy link
Contributor

kesselb commented Aug 22, 2024

/backport to stable29

@kesselb
Copy link
Contributor

kesselb commented Aug 22, 2024

/backport to stable28

@kesselb
Copy link
Contributor

kesselb commented Aug 22, 2024

/backport to stable30

@nickvergessen
Copy link
Member

Now it breaks real custom templates that do not extend the existing base class, but I guess I missed is_a($class, EMailTemplate::class, true) which means all of them should extend this.

@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 23, 2024
@nickvergessen nickvergessen merged commit 36f272d into nextcloud:master Aug 26, 2024
157 of 161 checks passed
Copy link

welcome bot commented Aug 26, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: custom mail template class is broken in 29.0.5 / 28.0.9
6 participants