Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bidirectional text support - Backend #47349

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Add bidirectional text support - Backend #47349

merged 5 commits into from
Sep 24, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 20, 2024 •
edited
Loading

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 31 milestone Aug 20, 2024
@nickvergessen nickvergessen changed the title Feat/31420/bidi backend support WIP - Add bidirectional text support - Backend Aug 20, 2024
@nickvergessen nickvergessen mentioned this pull request Aug 20, 2024
Merged
8 tasks
@nickvergessen nickvergessen force-pushed the feat/31420/bidi-backend-support branch from 08ff13d to ad9d7dc Compare August 20, 2024 14:33
icewind1991
icewind1991 previously approved these changes Aug 20, 2024
View reviewed changes
@susnux susnux changed the title WIP - Add bidirectional text support - Backend Add bidirectional text support - Backend Aug 20, 2024
@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 20, 2024
@susnux susnux requested review from skjnldsv, a team, yemkareems and provokateurin and removed request for a team August 20, 2024 16:29
provokateurin
provokateurin previously approved these changes Aug 20, 2024
View reviewed changes
skjnldsv
skjnldsv previously approved these changes Aug 20, 2024
View reviewed changes
@nickvergessen nickvergessen removed the request for review from yemkareems August 20, 2024 21:44
@nickvergessen nickvergessen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 20, 2024
@nickvergessen nickvergessen marked this pull request as draft August 20, 2024 21:50
ghorbani-ali and others added 5 commits September 23, 2024 16:59
@ghorbani-ali @nickvergessen
feat(rtl): Set layout direction based on language
2b7efd6 
Signed-off-by: ali ghorbani <ghorbani.ali.developer@gmail.com>
@ahangarha @nickvergessen
fix(rtl): Add unittest for language direction
d947452 
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
@nickvergessen
fix(rtl): Fix list of RTL languages
ae06ab5 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
ci: Restrict RTL characters to RTL languages
242f89a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(rtl): Make clear that the direction is based on language
82566c5 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen mentioned this pull request Sep 23, 2024
Closed
@nickvergessen nickvergessen marked this pull request as ready for review September 23, 2024 15:05
@nickvergessen nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 23, 2024
@nickvergessen nickvergessen merged commit 12ed773 into master Sep 24, 2024
176 of 178 checks passed
@nickvergessen nickvergessen deleted the feat/31420/bidi-backend-support branch September 24, 2024 09:27
@nickvergessen
Copy link
Member Author

/backport 242f89a to stable30

@nickvergessen
Copy link
Member Author

/backport 242f89a to stable29

@nickvergessen
Copy link
Member Author

/backport 242f89a to stable28

@backportbot backportbot bot mentioned this pull request Sep 24, 2024
Merged
1 task
This was referenced Sep 24, 2024
Merged
Merged
susnux
susnux reviewed Sep 25, 2024
View reviewed changes
build/translation-checker.php
'ps', // Pashto,
'ug', // 'Uyghurche / Uyghur
'ur_PK', // Urdu
'uz', // Uzbek Afghan
Copy link
Contributor

@susnux susnux Sep 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is wrong Uzbek is written in Latin script (LTR) only afghan Uzbek is RTL (uz_AF)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR welcome 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#48419

@AndyScherzinger
Copy link
Member

@ahangarha so the changes you made with some work on top by further engineers has been merged, so main branch now ships all the changes so far.

From here on the long list of small fixes will start I think and any PR can just target the master branch. Any discussion can happen on the Talk room as aligned some weeks ago.

Hope you are good and I think we are all happy with the current progress already, so let's take it from here and improve all the bits and pieces on bi-directional text support 🚀

@ahangarha
Copy link
Contributor

Great Job 👍🏾

This was referenced Oct 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux susnux left review comments

@skjnldsv skjnldsv skjnldsv approved these changes

@icewind1991 icewind1991 icewind1991 left review comments

@provokateurin provokateurin provokateurin left review comments

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement feature: language l10n and translations 🍀 2025-Spring
Projects
📁 Files team
Status: ☑️ Done
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
8 participants
@nickvergessen @skjnldsv @AndyScherzinger @ahangarha @icewind1991 @susnux @provokateurin @ghorbani-ali