fix(inherited-shares): ignore top root folder #47043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ArtificialOwl
commented
Aug 5, 2024
•
ArtificialOwl
commented
- Root folder can be ignored as never shared.
- Fix an issue with node id converted to 0 when browsing inherited shares, requesting too many resources.
- Fix an issue with inherited shares on external filesystem returning too many entries
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
icewind1991
approved these changes
Aug 5, 2024
come-nc
approved these changes
Aug 5, 2024
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.