Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Use @nextcloud/files filename validation to show more details #46753

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 25, 2024

Summary

This will enable showing more details what exactly is wrong with the filename. Especially with the new capabilities introduced with Nextcloud 30.

Screen recording

(the """ issue is resolved even if still in this recording ;) )

Bildschirmaufnahme_20240725_151530.webm

Checklist

@susnux susnux added the 3. to review Waiting for reviews label Jul 25, 2024
@susnux susnux requested a review from skjnldsv as a code owner July 25, 2024 13:09
@susnux susnux added this to the Nextcloud 30 milestone Jul 25, 2024
@susnux susnux added bug design Design, UI, UX, etc. feature: files labels Jul 25, 2024
…etails

This will enable showing more details what exactly is wrong with the filename.
Especially with the new capabilities introduced with Nextcloud 30.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/renaming-full-validation branch from e7edbb8 to c377205 Compare July 25, 2024 13:50
@susnux susnux mentioned this pull request Jul 25, 2024
@AndyScherzinger AndyScherzinger merged commit ba91f42 into master Jul 25, 2024
107 of 109 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/renaming-full-validation branch July 25, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants